From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34352)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SXCa4-0004sy-Ms
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:30:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SXCZu-0002Xa-Kz
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:30:28 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:38638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SXCZu-0002Wi-Bh
	for qemu-devel@nongnu.org; Wed, 23 May 2012 10:30:18 -0400
Received: by dadv2 with SMTP id v2so11776056dad.4
	for <qemu-devel@nongnu.org>; Wed, 23 May 2012 07:30:16 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FBCF46E.3020509@redhat.com>
Date: Wed, 23 May 2012 16:30:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120523135206.GA14654@chinaltcdragon.cn.ibm.com>
	<20120523141202.GC29930@redhat.com>
In-Reply-To: <20120523141202.GC29930@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Brian Zhao <zwanp@linux.vnet.ibm.com>, Kelvin Wang <senwang@linux.vnet.ibm.com>, Amos Kong <kongjianjun@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto:
>> > 2, Run qemu with the option -monitor.
>> > 
>> > 3, In the guest, insert necessary modules:
>> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done
>> > 
>> > 4, In the qemu monitor,hot add a virtio-scsi-pci adapter:
>> > (qemu)pci_add auto storage if=virtio-scsi-pci
>> > 
>> > 5, Check whether the controller was added:
>> > Guest: lspci
>> > Qemu: (qemu)info qtree
>> > 
>> > Signed-off-by: Kelvin Wang <senwang@linux.vnet.ibm.com>
>> > Signed-off-by: Sheng Liu <liusheng@linux.vnet.ibm.com>
> NAK
> 
> Do not use pci_add. It is a compatibility command.
> Use the new style device_add.
> Same for if=.
> 
> I think you won't need any changes then?
> 

You don't.  You need to rescan the bus manually in the guest, that's all.

Paolo