From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCdy-0006pM-FR for qemu-devel@nongnu.org; Wed, 23 May 2012 10:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXCds-0003fD-6k for qemu-devel@nongnu.org; Wed, 23 May 2012 10:34:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47427 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCds-0003eT-0S for qemu-devel@nongnu.org; Wed, 23 May 2012 10:34:24 -0400 Message-ID: <4FBCF566.3060902@suse.de> Date: Wed, 23 May 2012 16:34:14 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337504561-20297-1-git-send-email-gleb@redhat.com> <1337504561-20297-2-git-send-email-gleb@redhat.com> <4FBCE5A5.7050308@codemonkey.ws> In-Reply-To: <4FBCE5A5.7050308@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org, Gleb Natapov Am 23.05.2012 15:27, schrieb Anthony Liguori: > On 05/20/2012 04:02 AM, Gleb Natapov wrote: >> This patch adds two things. First it allows QEMU to distinguish betwee= n >> regular powerdown and S4 powerdown. Later separate QMP notification wi= ll >> be added for S4 powerdown. Second it allows S3/S4 states to be disable= d >> from QEMU command line. Some guests known to be broken with regards to >> power management, but allow to use it anyway. Using new properties >> management will be able to disable S3/S4 for such guests. >> >> Supported system state are passed to a firmware using new fw_cfg file. >> The file contains 6 byte array. Each byte represents one system >> state. If byte at offset X has its MSB set it means that system state >> X is supported and to enter it guest should use the value from lowest = 3 >> bits. >> >> Signed-off-by: Gleb Natapov >=20 > I see nothing wrong in principle here except that you should use a PTR > property to pass the fw_cfg object to the ACPI PM device. Paolo was on a quest to eliminate the PTR properties so I don't think we should advocate adding any more. Without having reviewed the code, I would suggest to rather QOM'ify the fw_cfg object and to use a link<> property if needed. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg