From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCmK-0002Sk-PX for qemu-devel@nongnu.org; Wed, 23 May 2012 10:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXCmG-0006rE-2F for qemu-devel@nongnu.org; Wed, 23 May 2012 10:43:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXCmF-0006qh-Pg for qemu-devel@nongnu.org; Wed, 23 May 2012 10:43:03 -0400 Message-ID: <4FBCF772.3040300@redhat.com> Date: Wed, 23 May 2012 16:42:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337504561-20297-1-git-send-email-gleb@redhat.com> <1337504561-20297-2-git-send-email-gleb@redhat.com> <4FBCE5A5.7050308@codemonkey.ws> <4FBCF566.3060902@suse.de> In-Reply-To: <4FBCF566.3060902@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Gleb Natapov , Anthony Liguori , qemu-devel@nongnu.org Il 23/05/2012 16:34, Andreas F=E4rber ha scritto: >> >=20 >> > I see nothing wrong in principle here except that you should use a P= TR >> > property to pass the fw_cfg object to the ACPI PM device. > Paolo was on a quest to eliminate the PTR properties so I don't think w= e > should advocate adding any more. Without having reviewed the code, I > would suggest to rather QOM'ify the fw_cfg object and to use a link<> > property if needed. Perhaps it should be the other way round. fw_cfg gets links to all the devices it has to expose information about. In the future it could be changed to an FWCfgProvider interface. Paolo