From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Gleb Natapov" <gleb@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.
Date: Wed, 23 May 2012 10:11:08 -0500 [thread overview]
Message-ID: <4FBCFE0C.9090407@codemonkey.ws> (raw)
In-Reply-To: <4FBCF772.3040300@redhat.com>
On 05/23/2012 09:42 AM, Paolo Bonzini wrote:
> Il 23/05/2012 16:34, Andreas Färber ha scritto:
>>>>
>>>> I see nothing wrong in principle here except that you should use a PTR
>>>> property to pass the fw_cfg object to the ACPI PM device.
>> Paolo was on a quest to eliminate the PTR properties so I don't think we
>> should advocate adding any more. Without having reviewed the code, I
>> would suggest to rather QOM'ify the fw_cfg object and to use a link<>
>> property if needed.
fw_cfg is already a QOM object. I think there's enough in the tree already to
do link<>s properly so that's definitely better than doing a PTR.
>
> Perhaps it should be the other way round. fw_cfg gets links to all the
> devices it has to expose information about. In the future it could be
> changed to an FWCfgProvider interface.
Yes, that does make more sense.
Regards,
Anthony Liguori
>
> Paolo
next prev parent reply other threads:[~2012-05-23 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 9:02 [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global Gleb Natapov
2012-05-20 9:02 ` [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states Gleb Natapov
2012-05-23 13:27 ` Anthony Liguori
2012-05-23 13:34 ` Gleb Natapov
2012-05-23 13:48 ` Anthony Liguori
2012-05-23 14:34 ` Andreas Färber
2012-05-23 14:42 ` Paolo Bonzini
2012-05-23 15:11 ` Anthony Liguori [this message]
2012-05-23 15:16 ` Gleb Natapov
2012-05-23 12:37 ` [Qemu-devel] [PATCH 1/2] Make pointer to fw_cfg device global Gleb Natapov
2012-05-23 13:25 ` Anthony Liguori
2012-05-23 13:32 ` Gleb Natapov
2012-05-23 13:46 ` Anthony Liguori
2012-05-23 12:44 ` Peter Maydell
2012-05-23 12:47 ` Gleb Natapov
2012-05-23 14:41 ` Andreas Färber
2012-05-23 14:54 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2012-05-14 12:34 Gleb Natapov
2012-05-14 12:34 ` [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBCFE0C.9090407@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=gleb@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).