From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXE01-0008Ij-DV for qemu-devel@nongnu.org; Wed, 23 May 2012 12:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXDzs-0006ri-7V for qemu-devel@nongnu.org; Wed, 23 May 2012 12:01:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXDzr-0006pO-W2 for qemu-devel@nongnu.org; Wed, 23 May 2012 12:01:12 -0400 Message-ID: <4FBD09BE.8080305@redhat.com> Date: Wed, 23 May 2012 10:01:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120522230955.5F24540404@buildbot.b1-systems.de> <4FBC242A.4080107@suse.de> <20120523103954.27b13af7@doriath.home> <20120523113549.346baf42@doriath.home> <20120523125711.783be240@doriath.home> In-Reply-To: <20120523125711.783be240@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDAFF337A2CE7796AE7BF7098" Subject: Re: [Qemu-devel] buildbot failure in qemu on default_openbsd_current List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: agraf@suse.de, qemu-devel@nongnu.org, dunrong huang , Michael Roth , qemu@buildbot.b1-systems.de, gollub@b1-systems.de, =?ISO-8859-1?Q?Andreas_F=E4rb?= =?ISO-8859-1?Q?er?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDAFF337A2CE7796AE7BF7098 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/23/2012 09:57 AM, Luiz Capitulino wrote: >=20 > Anyone knows what I did wrong? Or, if anybody could test the attached f= ix... Sorry, I'm not in a position to test the patch, but I can at least review it. >=20 >=20 > 0001-qemu-ga-Fix-missing-environ-declarion.patch >=20 >=20 >>>From 4a3f4cff8aa27fe3810d621d20bf90f18ca8e2d5 Mon Sep 17 00:00:00 2001 > From: Luiz Capitulino > Date: Wed, 23 May 2012 11:33:51 -0300 > Subject: [PATCH] qemu-ga: Fix missing environ declarion s/declarion/declaration/ >=20 > Commit 3674838cd05268954bb6473239cd7f700a79bf0f uses the environ > global variable, but is relying on it to be declared somewhere else. >=20 > This works for Linux because _GNU_SOURCE declares it, but it brakes s/brakes/breaks/ > for system where _GNU_SOURCE is not declared, such as OpenBSD. >=20 > Fix it by declaring environ when _GNU_SOURCE is not defined. >=20 > Signed-off-by: Luiz Capitulino > --- > qga/commands-posix.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 7664be1..304ffa8 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -12,6 +12,7 @@ > */ > =20 > #include > +#include > #include > #include > #include "qga/guest-agent-core.h" > @@ -20,6 +21,10 @@ > #include "qemu-queue.h" > #include "host-utils.h" > =20 > +#ifndef _GNU_SOURCE > +extern char **environ; > +#endif Looks reasonable. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDAFF337A2CE7796AE7BF7098 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPvQm/AAoJEKeha0olJ0NqowoIAIL3O+RNE98hDstFuwETJRj/ IV6WXvt2TjBk7eZVrd90MaMelKJX9SM3dskY9suWnpCN0fb5cZ+hI27FK+vpbduH izHNVxxPc7diED/Qx/Vknwuu6FeZ8Wfcr2ewVmdVS2ViGg1ihLSnPcP1fbRR2Xmw FZZaJwrtq0LgPXlCF3CowE3vhdVE/syCmr0aae7ElNAnveXuR33aKj11vF/5NbaT tzptmg4ZsCYp42owDtTqU9Kf2HMy9ZKnzXjo9zmkC9qD472XwlFukbdrBuCP+uhU HyNPjZli01gfoeFDN6Ado5ILSXVPuvTjNEMjAaQeK6VBaOfLKPQIf13eeyb2ggc= =Z0dK -----END PGP SIGNATURE----- --------------enigDAFF337A2CE7796AE7BF7098--