From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXE7H-0005LR-I6 for qemu-devel@nongnu.org; Wed, 23 May 2012 12:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXE7B-0002M0-Mk for qemu-devel@nongnu.org; Wed, 23 May 2012 12:08:51 -0400 Received: from e24smtp01.br.ibm.com ([32.104.18.85]:58006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXE7B-0002K9-C7 for qemu-devel@nongnu.org; Wed, 23 May 2012 12:08:45 -0400 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 23 May 2012 13:08:40 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id EE5FD1DC004B for ; Wed, 23 May 2012 13:08:32 -0300 (BRT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4NG8B7e36176128 for ; Wed, 23 May 2012 13:08:12 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4NG8cPw022526 for ; Wed, 23 May 2012 13:08:38 -0300 Message-ID: <4FBD0B85.4090605@linux.vnet.ibm.com> Date: Wed, 23 May 2012 13:08:37 -0300 From: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= MIME-Version: 1.0 References: <1337721011-20842-1-git-send-email-vianac@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org Hi Peter, Thanks for all your tips! > OK, this has been bugging me for the last three versions, and > since I'm complaining about other things anyway: can you reword > this commit message, please, so that it is a standalone paragraph > explaining (a) what the commit does and (b) why it is doing it, rather > than being a combination of an unattributed quote from Anthony and some > new text from you. Commit messages aren't emails. > Explanatory remarks like the URL to the previous discussion can go > below the '---' line where they won't appear in the formal git commit > message. Ok, I rewrote the commit message. > When you're posting a new version of a patch please include a > summary of changes since the previous version below the '---' > line. Ok. > So when you posted the previous version of your patch it was pointed > out that this is a buffer overflow: > http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg01657.html > > You need to fix this. I have sent a reply to that thread explaining that the user actually doesn't have control of that string, that is only used internally in the code (just like the QEMU_VERSION macro). I fixed the code now with snprintf copying at most 12 chars to the string (the array size). I can't think of why pstrcat would be better in this case, as suggested by Erik. > The questions about the usb-redir version still apply too: > http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg01700.html I have also sent a reply to that thread asking if the usb-redir version appears to the guest but I haven't got no answer. > Don't just leave things unchanged from previous versions that were objected > to without explicitly mentioning them in the below-the-'---' commentary (ie > explaining why you decided not to change them), please. Otherwise reviewers > have to go through the whole thing with a fine tooth comb rechecking whether > you've actually fixed anything. I didn't know there was "patch changelog protocol" here, I'll do it from now on. Best regards, Crístian.