From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXFXh-0003K6-OI for qemu-devel@nongnu.org; Wed, 23 May 2012 13:40:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXFXf-0003gF-JY for qemu-devel@nongnu.org; Wed, 23 May 2012 13:40:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58740 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXFXf-0003es-Cy for qemu-devel@nongnu.org; Wed, 23 May 2012 13:40:11 -0400 Message-ID: <4FBD20F0.3000306@suse.de> Date: Wed, 23 May 2012 19:40:00 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-7-git-send-email-pbonzini@redhat.com> <4FBD190B.60800@suse.de> <4FBD1BF3.5000901@redhat.com> In-Reply-To: <4FBD1BF3.5000901@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/21] qdev: push "type" property up to Object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , peter.maydell@linaro.org Cc: Blue Swirl , aliguori@us.ibm.com, qemu-devel@nongnu.org Am 23.05.2012 19:18, schrieb Paolo Bonzini: > Il 23/05/2012 19:06, Andreas F=E4rber ha scritto: >> Am 02.05.2012 13:30, schrieb Paolo Bonzini: >>> Now that Object is a type, add an instance_init function and push >>> the "type" property from qdev to there. >>> >>> Signed-off-by: Paolo Bonzini >> >> The rebased version from qdev-props-4 breaks and hangs `make check`: >> >> GTESTER check-qtest-sparc >> qemu-system-sparc: Insufficient permission to perform this operation >> >> Paolo, can you please investigate? >=20 > Please try this patch (untested; please add my signed-off-by if you end > up committing it). Tested make check and PReP. I added some braces missing in the original code to please checkpatch.pl and applied both to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Paolo, please let me know if you're okay with my commit messages, then I can override the author to be you as well (same for preceding one). BTW note that I usually update subjects to start with a capital letter to visually separate the lowercase topic from the actual summary. ;) > There is also a "type" property in arm_l2x0.c, but it seems unused. Peter, can we drop that property? I'd insert such a patch before then. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg