From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXIQB-0006TL-J8 for qemu-devel@nongnu.org; Wed, 23 May 2012 16:44:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXIQ9-0000Pr-Ab for qemu-devel@nongnu.org; Wed, 23 May 2012 16:44:39 -0400 Received: from mail-gg0-f173.google.com ([209.85.161.173]:37782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXIQ9-0000P8-4r for qemu-devel@nongnu.org; Wed, 23 May 2012 16:44:37 -0400 Received: by ggnp1 with SMTP id p1so8561322ggn.4 for ; Wed, 23 May 2012 13:44:34 -0700 (PDT) Message-ID: <4FBD4C2F.5080606@codemonkey.ws> Date: Wed, 23 May 2012 15:44:31 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4FBC5C67.1080007@suse.de> <4FBD42D9.6050809@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel , TeLeMan , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Avi Kivity On 05/23/2012 03:28 PM, Blue Swirl wrote: > On Wed, May 23, 2012 at 8:04 PM, Andreas Färber wrote: >> Am 23.05.2012 21:40, schrieb Blue Swirl: >>> On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: >>>> Am 18.05.2012 11:49, schrieb TeLeMan: >>>>> This breakage was introduced by the commit "memory: make >>>>> phys_page_find() return an unadjusted". >>>> >>>> You seem to have found the origin of your problem. If you also mention >>>> the commit hash in your commit message then certain frontends (gitk, >>>> repo.or.cz) will display it as a handy hyperlink to that commit. >>>> >>>>> >>>>> Signed-off-by: TeLeMan >>>> >>>> Signed-off-by is a legal statement of origin and must not be a pseudonym. >>> >>> $ git log --author=.*eleman >>> commit c62f6d1d76aea587556c85b6b7b5c44167006264 >>> Author: TeLeMan >>> Date: Mon Jul 25 16:29:14 2011 +0800 >>> >>> monitor: fix build breakage with --disable-vnc >>> >>> The breakage was introduced by the commit >>> 13661089810d3e59931f3e80d7cb541b99af7071 >>> >>> Signed-off-by: TeLeMan >>> Signed-off-by: Anthony Liguori >>> >>> and several others. >> >> Funny, since I learned that from Anthony. :-) Signed-off-by is a contractual statement and your real name is required: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches#l339 But I'm generally going to assume that if you SoB something, it's your real name. I have challenged people in the past but only when it's very obviously fake. If TeLeMan is not your real name, you cannot Signed-off-by with it. Regards, Anthony Liguori