From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJqA-00083I-1r for qemu-devel@nongnu.org; Wed, 23 May 2012 18:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXJq8-0006Fp-Bh for qemu-devel@nongnu.org; Wed, 23 May 2012 18:15:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42293 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXJq8-0006Fa-5E for qemu-devel@nongnu.org; Wed, 23 May 2012 18:15:32 -0400 Message-ID: <4FBD6176.20702@suse.de> Date: Thu, 24 May 2012 00:15:18 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337798885-23070-1-git-send-email-lcapitulino@redhat.com> <20120523200843.GB2916@illuin> <20120523182536.687fcae8@doriath.home> <20120523220239.GB5615@illuin> In-Reply-To: <20120523220239.GB5615@illuin> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1.1 0/2]: qemu-ga: fix build on openbsd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aliguori@us.ibm.com, kraxel@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Am 24.05.2012 00:02, schrieb Michael Roth: > On Wed, May 23, 2012 at 06:25:36PM -0300, Luiz Capitulino wrote: >> All the -Wno-redundant-decls warnings are still there on 5.1, if I rem= ove that >> flag I still get the following ones. Michael, do you want me to fix th= e qemu-ga >> one for 1.1? [...] > The sprintf() has been there for a while now so I think it's okay to fi= x > later since openbsd does seem to have enough coverage to catch qemu-ga > breakages and it hasn't been mentioned yet. The buildbot did catch it and so did I, unfortunately. The issue here is rather that a) your qemu-ga branch is still not covered by the buildbots (Stefan told me the other day we need to contact Daniel Gollub for that), and b) Anthony tested all PULLs locally instead of pushing early so that the existing build bots could've detect any breakage on master before rc3 was set in stone. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg