From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SXO2T-0000t7-MR
	for qemu-devel@nongnu.org; Wed, 23 May 2012 22:44:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SXO2R-0004l8-OS
	for qemu-devel@nongnu.org; Wed, 23 May 2012 22:44:33 -0400
Received: from fmmailgate03.web.de ([217.72.192.234]:43034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1SXO2R-0004kn-Ef
	for qemu-devel@nongnu.org; Wed, 23 May 2012 22:44:31 -0400
Received: from moweb001.kundenserver.de (moweb001.kundenserver.de
	[172.19.20.114])
	by fmmailgate03.web.de (Postfix) with ESMTP id D90251B4EB250
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 04:44:29 +0200 (CEST)
Message-ID: <4FBDA089.9040209@web.de>
Date: Wed, 23 May 2012 23:44:25 -0300
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4FBD9E3A.6080704@web.de>
In-Reply-To: <4FBD9E3A.6080704@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig4A738F96ECFBE84D7B0E06BC"
Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint
	insertion/deletion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>, Avi Kivity <avi@redhat.com>, TeLeMan <geleman@gmail.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig4A738F96ECFBE84D7B0E06BC
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2012-05-23 23:34, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>=20
> tb_invalidate_phys_addr has to called with the exact physical address o=
f
> the breakpoint we add/remove, not just the page's base address.
> Otherwise we easily fail to flush the right TB.
>=20
> Regression of 1e7855a558.

Sorry, forgot the tag: this should go in before 1.1 of course.

>=20
> Reported-by: TeLeMan <geleman@gmail.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  exec.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>=20
> diff --git a/exec.c b/exec.c
> index a0494c7..efa1345 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1492,7 +1492,8 @@ void tb_invalidate_phys_addr(target_phys_addr_t a=
ddr)
> =20
>  static void breakpoint_invalidate(CPUArchState *env, target_ulong pc)
>  {
> -    tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc));
> +    tb_invalidate_phys_addr(cpu_get_phys_page_debug(env, pc) +
> +                            (pc & ~TARGET_PAGE_MASK));
>  }
>  #endif
>  #endif /* TARGET_HAS_ICE */


--------------enig4A738F96ECFBE84D7B0E06BC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk+9oIoACgkQitSsb3rl5xSXfACfaPIuUL3C0HxxBtb9waQwJy0t
U/IAoNYa8Wr8ht5Wdx8VtyGaNHUjPQv8
=wqmk
-----END PGP SIGNATURE-----

--------------enig4A738F96ECFBE84D7B0E06BC--