From: Gerd Hoffmann <kraxel@redhat.com>
To: malc <av1474@comtv.ru>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit
Date: Thu, 24 May 2012 09:10:37 +0200 [thread overview]
Message-ID: <4FBDDEED.9010203@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1205032332230.3296@linmac>
On 05/03/12 21:32, malc wrote:
> On Thu, 3 May 2012, Jan Kiszka wrote:
>
>> Not only clean up enabled voices but any registered one. Backends like
>> pulsaudio rely on unconditional fini handler invocations.
>>
>> This fixes "Memory pool destroyed but not all memory blocks freed!"
>> warnings on VM shutdowns when pa is used.
>
> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?
>
> [..snip..]
Waded through the source. Have to agree with Jan here: Handling this
via VOICE_{ENABLE,DISABLE} isn't going to fly. It would mean to move
the complete pulseaudio setup (connect to daemon, create streams, create
worker thread, ...).from init() to VOICE_ENABLE so we can cleanup in
VOICE_DISABLE and don't need fini(). This isn't how it is supposed to
work ...
cheers,
Gerd
next prev parent reply other threads:[~2012-05-24 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 18:56 [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit Jan Kiszka
2012-05-03 19:32 ` malc
2012-05-03 20:02 ` Jan Kiszka
2012-05-03 23:51 ` malc
2012-05-09 19:27 ` Jan Kiszka
2012-05-09 19:33 ` malc
2012-05-16 18:01 ` Jan Kiszka
2012-05-24 7:10 ` Gerd Hoffmann [this message]
2012-05-24 7:11 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDDEED.9010203@redhat.com \
--to=kraxel@redhat.com \
--cc=av1474@comtv.ru \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).