From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXSCB-0000nC-Bg for qemu-devel@nongnu.org; Thu, 24 May 2012 03:10:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXSC9-0003og-K3 for qemu-devel@nongnu.org; Thu, 24 May 2012 03:10:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXSC9-0003oD-Aq for qemu-devel@nongnu.org; Thu, 24 May 2012 03:10:49 -0400 Message-ID: <4FBDDEED.9010203@redhat.com> Date: Thu, 24 May 2012 09:10:37 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <4FA2D4C8.7010007@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Jan Kiszka , qemu-devel On 05/03/12 21:32, malc wrote: > On Thu, 3 May 2012, Jan Kiszka wrote: > >> Not only clean up enabled voices but any registered one. Backends like >> pulsaudio rely on unconditional fini handler invocations. >> >> This fixes "Memory pool destroyed but not all memory blocks freed!" >> warnings on VM shutdowns when pa is used. > > Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]? > > [..snip..] Waded through the source. Have to agree with Jan here: Handling this via VOICE_{ENABLE,DISABLE} isn't going to fly. It would mean to move the complete pulseaudio setup (connect to daemon, create streams, create worker thread, ...).from init() to VOICE_ENABLE so we can cleanup in VOICE_DISABLE and don't need fini(). This isn't how it is supposed to work ... cheers, Gerd