From: Jan Kiszka <jan.kiszka@siemens.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion
Date: Thu, 24 May 2012 08:25:12 -0300 [thread overview]
Message-ID: <4FBE1A98.3090708@siemens.com> (raw)
In-Reply-To: <CAMo8Bf+pWij2ojdGT02Fyo+DmbMjxvAzOm6sV_f-D7vaJDE_AQ@mail.gmail.com>
On 2012-05-24 07:51, Max Filippov wrote:
> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> tb_invalidate_phys_addr has to called with the exact physical address of
>> the breakpoint we add/remove, not just the page's base address.
>> Otherwise we easily fail to flush the right TB.
>>
>> Regression of 1e7855a558.
>
> Sorry, I fail to see how 1e7855a558 could introduce a regression, it
> just rearranged the code.
> Even more, AFAIK cpu_get_phys_page_debug returns complete physical
> address, not just
> physical page. Probably it has a misleading name.
Unfortunately, cpu_get_phys_page_debug does NOT deliver the sub-page
offset, only the page base address. So the regression was caused by this
refactoring.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-05-24 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 2:34 [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion Jan Kiszka
2012-05-24 2:44 ` Jan Kiszka
2012-05-24 10:51 ` Max Filippov
2012-05-24 11:25 ` Jan Kiszka [this message]
2012-05-24 12:08 ` Max Filippov
2012-05-24 12:16 ` Jan Kiszka
2012-05-24 12:42 ` Max Filippov
2012-05-24 13:26 ` Jan Kiszka
2012-05-24 14:11 ` Max Filippov
2012-05-24 14:21 ` Jan Kiszka
2012-05-24 14:29 ` Max Filippov
2012-05-24 14:34 ` Jan Kiszka
2012-05-24 14:26 ` Avi Kivity
2012-05-24 19:58 ` Max Filippov
2012-05-28 9:34 ` Avi Kivity
2012-05-28 11:54 ` Max Filippov
2012-05-28 12:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE1A98.3090708@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=geleman@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).