From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXX2M-0000rT-5I for qemu-devel@nongnu.org; Thu, 24 May 2012 08:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXX2D-0007BR-FL for qemu-devel@nongnu.org; Thu, 24 May 2012 08:21:01 -0400 Received: from david.siemens.de ([192.35.17.14]:28626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXX2D-0007AN-6A for qemu-devel@nongnu.org; Thu, 24 May 2012 08:20:53 -0400 Message-ID: <4FBE279D.1010201@siemens.com> Date: Thu, 24 May 2012 09:20:45 -0300 From: Jan Kiszka MIME-Version: 1.0 References: <1337849095-21444-1-git-send-email-kraxel@redhat.com> <1337849095-21444-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1337849095-21444-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 2/2] vga: make vram size configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On 2012-05-24 05:44, Gerd Hoffmann wrote: > Zap the global VGA_RAM_SIZE #define, make the vga ram size configurable > for standard vga and vmware vga. cirrus and qxl are left with a fixed > size (and private VGA_RAM_SIZE #define) for now. > > qxl needs some non-trivial adjustments in the mode list handling deal > with a runtime-configurable size, which calls for a separate qxl patch. > > cirrus emulates cards which have 2 MB (isa) and 4 MB (pci), so I guess > it would make sense to use these sizes. That change would break > migration though, so I left it fixed at 8 MB size. Making it > configurabls is pretty pointless for cirrus as we have to match real > hardware. We still have the concept of compat machines. So raise to defaults to more handy sizes should be feasible, provided we keep the old values for legacy machines. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux