From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXXUC-00019q-BB
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:49:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXXU7-0005sU-KH
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:49:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:47236 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXXU7-0005s2-DY
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:49:43 -0400
Message-ID: <4FBE2E5E.6010107@suse.de>
Date: Thu, 24 May 2012 14:49:34 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <002901cd3980$b8d4e6d0$2a7eb470$@Dovgaluk@ispras.ru>
In-Reply-To: <002901cd3980$b8d4e6d0$2a7eb470$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>
Cc: 'qemu-devel' <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

Am 24.05.2012 09:42, schrieb Pavel Dovgaluk:
> Prevent disk data loss when closing qemu console window
> under Windows 7.
>=20
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---
>  os-win32.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>=20
> diff --git a/os-win32.c b/os-win32.c
> index ad76370..66c39b8 100644
> --- a/os-win32.c
> +++ b/os-win32.c
> @@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int =
overwrite)
> =20
>  static BOOL WINAPI qemu_ctrl_handler(DWORD type)
>  {
> -    exit(STATUS_CONTROL_C_EXIT);
> +    qemu_system_shutdown_request();
> +    /* Windows 7 kills application when the function returns.
> +       Sleep here to give QEMU a try for closing */
> +    Sleep(10000);

How do we know that 10000 is enough? Shouldn't we rather block until
receipt of some completion signal?

Andreas

> +
>      return TRUE;
>  }
>=20

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg