From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34274)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXXcP-0004wL-QN
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXXcJ-0000AV-J0
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:17 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:56142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SXXcJ-0000A9-E1
	for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:11 -0400
Received: by obbwd20 with SMTP id wd20so15498547obb.4
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 05:58:09 -0700 (PDT)
Message-ID: <4FBE305D.3020705@codemonkey.ws>
Date: Thu, 24 May 2012 07:58:05 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1337859784-24097-1-git-send-email-armbru@redhat.com>
	<1337859784-24097-3-git-send-email-armbru@redhat.com>
	<4FBE20B0.5010808@redhat.com>
In-Reply-To: <4FBE20B0.5010808@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, afaerber@suse.de, qemu-devel@nongnu.org

On 05/24/2012 06:51 AM, Paolo Bonzini wrote:
> Il 24/05/2012 13:43, Markus Armbruster ha scritto:
>> Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack
>> additional magic performed by qdev_try_create(), and almost certainly
>> won't work.
>
> True.  With the patches on the list, all that adev_try_create does is really
>
>      dev->parent_bus = bus;
>      bus_add_child(bus, dev);
>
> We should change that to a parent_bus property,

parent_bus is a property with the QOM bus series (which is part of your Push, 
push, series, no?).

You still can't add a bus as a child.  We need a magic child[*] link that acts 
like a clone file.  Shouldn't be hard to add.

Regards,

Anthony Liguori

  so that device_add is
> really qom-new + qom-set parent_bus.
>
> Paolo