From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXXcs-0005d9-Ug for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXXcq-0000IQ-9z for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXXcq-0000Hx-25 for qemu-devel@nongnu.org; Thu, 24 May 2012 08:58:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4OCwgc9025938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 May 2012 08:58:42 -0400 Message-ID: <4FBE3080.9040201@redhat.com> Date: Thu, 24 May 2012 14:58:40 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <4FBDF65F.8070609@redhat.com> <1337852294-12224-1-git-send-email-alevy@redhat.com> <1337852294-12224-3-git-send-email-alevy@redhat.com> In-Reply-To: <1337852294-12224-3-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 05/24/12 11:38, Alon Levy wrote: > For all devices print id, mode and guest_bug status. Queued up 1+2+4 For this one I wanna have an additional ack from qmp camp. Also a nit: > # @SpiceInfo > # > # Information about the SPICE session. > @@ -683,12 +721,17 @@ > # > # @channels: a list of @SpiceChannel for each active spice channel > # > +# @qxl0_mode: Mode of the primary qxl device. > +# > +# @qxl0_guest_bug: Guest bug status of primary qxl device. > +# Code changed, but docs didn't ... Otherwise looks fine to me. cheers, Gerd