From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXXfl-0006UG-0f for qemu-devel@nongnu.org; Thu, 24 May 2012 09:01:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXXfi-0001JQ-WE for qemu-devel@nongnu.org; Thu, 24 May 2012 09:01:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47865 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXXfi-0001J5-Pz for qemu-devel@nongnu.org; Thu, 24 May 2012 09:01:42 -0400 Message-ID: <4FBE312F.40902@suse.de> Date: Thu, 24 May 2012 15:01:35 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337859784-24097-1-git-send-email-armbru@redhat.com> <1337859784-24097-3-git-send-email-armbru@redhat.com> <4FBE20B0.5010808@redhat.com> <4FBE305D.3020705@codemonkey.ws> In-Reply-To: <4FBE305D.3020705@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , Markus Armbruster , qemu-devel@nongnu.org Am 24.05.2012 14:58, schrieb Anthony Liguori: > On 05/24/2012 06:51 AM, Paolo Bonzini wrote: >> Il 24/05/2012 13:43, Markus Armbruster ha scritto: >>> Note: qdev objects (subtype of TYPE_DEVICE) created with qom-new lack >>> additional magic performed by qdev_try_create(), and almost certainly >>> won't work. >> >> True. With the patches on the list, all that adev_try_create does is >> really >> >> dev->parent_bus =3D bus; >> bus_add_child(bus, dev); >> >> We should change that to a parent_bus property, >=20 > parent_bus is a property with the QOM bus series (which is part of your > Push, push, series, no?). Note it's on qom-next already since last night but I discovered a minor issue where I am going to move some code between two patches of yours for consistency. Will send out official notices when I'm done. Andreas >=20 > You still can't add a bus as a child. We need a magic child[*] link > that acts like a clone file. Shouldn't be hard to add. >=20 > Regards, >=20 > Anthony Liguori >=20 > so that device_add is >> really qom-new + qom-set parent_bus. >> >> Paolo >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg