* Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu
[not found] <41561.0733711675$1337845368@news.gmane.org>
@ 2012-05-24 10:10 ` Paolo Bonzini
2012-05-24 13:11 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2012-05-24 10:10 UTC (permalink / raw)
To: Pavel Dovgaluk; +Cc: 'qemu-devel', Anthony Liguori
Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto:
> Prevent disk data loss when closing qemu console window
> under Windows 7.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---
> os-win32.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/os-win32.c b/os-win32.c
> index ad76370..66c39b8 100644
> --- a/os-win32.c
> +++ b/os-win32.c
> @@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int overwrite)
>
> static BOOL WINAPI qemu_ctrl_handler(DWORD type)
> {
> - exit(STATUS_CONTROL_C_EXIT);
> + qemu_system_shutdown_request();
> + /* Windows 7 kills application when the function returns.
> + Sleep here to give QEMU a try for closing */
> + Sleep(10000);
> +
> return TRUE;
> }
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Anthony, can you queue it for 1.1?
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu
2012-05-24 10:10 ` [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu Paolo Bonzini
@ 2012-05-24 13:11 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2012-05-24 13:11 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: 'qemu-devel', Pavel Dovgaluk
On 05/24/2012 05:10 AM, Paolo Bonzini wrote:
> Il 24/05/2012 09:42, Pavel Dovgaluk ha scritto:
>> Prevent disk data loss when closing qemu console window
>> under Windows 7.
>>
>> Signed-off-by: Pavel Dovgalyuk<pavel.dovgaluk@gmail.com>
>> ---
>> os-win32.c | 6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/os-win32.c b/os-win32.c
>> index ad76370..66c39b8 100644
>> --- a/os-win32.c
>> +++ b/os-win32.c
>> @@ -57,7 +57,11 @@ int setenv(const char *name, const char *value, int overwrite)
>>
>> static BOOL WINAPI qemu_ctrl_handler(DWORD type)
>> {
>> - exit(STATUS_CONTROL_C_EXIT);
>> + qemu_system_shutdown_request();
>> + /* Windows 7 kills application when the function returns.
>> + Sleep here to give QEMU a try for closing */
>> + Sleep(10000);
>> +
>> return TRUE;
>> }
>
> Reviewed-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Anthony, can you queue it for 1.1?
Is that a 10 second sleep? I really think this needs a much, much better commit
message. Random sleeps like this are poison and need to be carefully justified.
Regards,
Anthony Liguori
>
> Paolo
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-24 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <41561.0733711675$1337845368@news.gmane.org>
2012-05-24 10:10 ` [Qemu-devel] [PATCH 1.1 v2] Prevent disk data loss when closing qemu Paolo Bonzini
2012-05-24 13:11 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).