From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXYD2-0003P4-8O for qemu-devel@nongnu.org; Thu, 24 May 2012 09:36:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXYCv-0003Fy-DS for qemu-devel@nongnu.org; Thu, 24 May 2012 09:36:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49148 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXYCv-0003Eb-3y for qemu-devel@nongnu.org; Thu, 24 May 2012 09:36:01 -0400 Message-ID: <4FBE393A.4090508@suse.de> Date: Thu, 24 May 2012 15:35:54 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <4FBC5C67.1080007@suse.de> <4FBD42D9.6050809@suse.de> <4FBD4C2F.5080606@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: TeLeMan Cc: Blue Swirl , Avi Kivity , Anthony Liguori , qemu-devel Am 24.05.2012 04:12, schrieb TeLeMan: > I won't use > my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's a certification of whom the code came from and who would be to blame if anything was wrong with that (think non-GPL-compatible code taken from somewhere else). Why should you be granted more privacy than us just because your name is Chinese? There's quite a few Chinese IBM guys around that don't seem to have any problem with this, and git would even handle UTF-8 characters quite well if desired[*]. Andreas [*] For example, commit e965fc380703110e967febf8d5b2ecd7db53b5d2 Author: =E9=99=B3=E9=9F=8B=E4=BB=BB Date: Mon Feb 6 14:02:55 2012 +0800 cpu-exec.c: Correct comment about this file and indentation cleanup Each target uses the #define macro (in target-xxx/cpu.h) to rename cpu_exec (cpu-exec.c) to cpu_xxx_exec, then defines its own cpu_loop which calls cpu_xxx_exec. So basically, cpu-exec.c is not only the i3= 86 emulator main execution loop. This patch corrects the comment of this file and does indentation cleanup. Signed-off-by: Chen Wei-Ren (=E9=99=B3=E9=9F=8B=E4=BB=BB) Signed-off-by: Stefan Hajnoczi --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg