From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
'qemu-devel' <qemu-devel@nongnu.org>,
Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu
Date: Thu, 24 May 2012 15:46:49 +0200 [thread overview]
Message-ID: <4FBE3BC9.6070203@redhat.com> (raw)
In-Reply-To: <4FBE2E5E.6010107@suse.de>
Il 24/05/2012 14:49, Andreas Färber ha scritto:
>> > - exit(STATUS_CONTROL_C_EXIT);
>> > + qemu_system_shutdown_request();
>> > + /* Windows 7 kills application when the function returns.
>> > + Sleep here to give QEMU a try for closing */
>> > + Sleep(10000);
> How do we know that 10000 is enough? Shouldn't we rather block until
> receipt of some completion signal?
After 10s Windows will kill us anyway. Think of it as SIGTERM/SIGKILL.
Using a completion signal would be more polite (the QEMU process would
disappear as soon as possible), but the outcome would be the same.
Paolo
prev parent reply other threads:[~2012-05-24 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 7:42 [Qemu-devel] [PATCH v2] Prevent disk data loss when closing qemu Pavel Dovgaluk
2012-05-24 12:49 ` Andreas Färber
2012-05-24 13:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE3BC9.6070203@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).