From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32902)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SXe7V-0000Uu-Ke
	for qemu-devel@nongnu.org; Thu, 24 May 2012 15:54:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SXe7T-00008q-Te
	for qemu-devel@nongnu.org; Thu, 24 May 2012 15:54:49 -0400
Received: from e24smtp04.br.ibm.com ([32.104.18.25]:51571)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SXe7T-000061-Id
	for qemu-devel@nongnu.org; Thu, 24 May 2012 15:54:47 -0400
Received: from /spool/local
	by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <vianac@linux.vnet.ibm.com>;
	Thu, 24 May 2012 16:54:32 -0300
Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26])
	by d24dlp01.br.ibm.com (Postfix) with ESMTP id ED1573520044
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 16:54:25 -0300 (BRT)
Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95])
	by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q4OJs1kV29622344
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 16:54:01 -0300
Received: from d24av03.br.ibm.com (loopback [127.0.0.1])
	by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q4OHsjcX030505
	for <qemu-devel@nongnu.org>; Thu, 24 May 2012 14:54:45 -0300
Message-ID: <4FBE91F3.3050502@linux.vnet.ibm.com>
Date: Thu, 24 May 2012 16:54:27 -0300
From: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= <vianac@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1337721011-20842-1-git-send-email-vianac@linux.vnet.ibm.com>
	<CAFEAcA_sxBoR0iVZp+DTSzb924Nt4WLZ_j=GKwMRz7f-pSBV-A@mail.gmail.com>
	<4FBD0B85.4090605@linux.vnet.ibm.com>	<4FBD0C3C.1000505@redhat.com>
	<4FBD434D.9030706@linux.vnet.ibm.com>
	<CAFEAcA_6Te6fgTYES7pesjhH8in_3QMR3-czcKgvUxqLHeWoeA@mail.gmail.com>
In-Reply-To: <CAFEAcA_6Te6fgTYES7pesjhH8in_3QMR3-czcKgvUxqLHeWoeA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the
 QEMU_VERSION that's exposed via hardware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

On 23-05-2012 17:54, Peter Maydell wrote:
> The point is that your snprintf is not actually using the full power of
> a format string parser, it's just concatenating two strings ("QEMU "
> and the version). The simple way to put two strings into a buffer
> one after the other is to copy string A and then concatenate string
> B on the end.
I got it. That has been fixed in three snippets of my patch, thanks!

Best regards,
Crístian.