From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXlYa-0001pk-GK for qemu-devel@nongnu.org; Thu, 24 May 2012 23:51:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXlYY-0002Jh-J7 for qemu-devel@nongnu.org; Thu, 24 May 2012 23:51:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXlYY-0002JK-Aq for qemu-devel@nongnu.org; Thu, 24 May 2012 23:51:14 -0400 Message-ID: <4FBF01AE.5000007@redhat.com> Date: Thu, 24 May 2012 21:51:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1337916721-14308-1-git-send-email-akong@redhat.com> <1337916721-14308-3-git-send-email-akong@redhat.com> In-Reply-To: <1337916721-14308-3-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig39D2CF01E431471A4F45F883" Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig39D2CF01E431471A4F45F883 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/24/2012 09:32 PM, Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on some variables > in monitor.c, so reserve qmp_sendkey() to monitor.c > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' >=20 > Signed-off-by: Amos Kong > +## > +# @sendkey: > +# > +# Send keys to VM. > +# > +# @keys: key sequence > +# @hold-time: time to delay key up events > +# > +# Returns: Nothing on success > +# If key is unknown or redundant, QERR_INVALID_PARAMETER > +# If key is invalid, QERR_INVALID_PARAMETER_VALUE > +# > +# Notes: Send @var{keys} to the emulator. @var{keys} could be the name= of the > +# key or the raw value in either decimal or hexadecimal format= =2E Use > +# @code{-} to press several keys simultaneously. > +# > +# Since: 0.14.0 > +## > +{ 'command': 'sendkey', 'data': {'keys': 'str', '*hold-time': 'int'} }= Rather than making 'keys' a free-form string where qemu then has to parse '-' to separate keys, should we instead make it a JSON array? For example, { "execute":"sendky", "data":{ "keys":["ctrl", "alt", "del"], "hold-time":200 } } --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig39D2CF01E431471A4F45F883 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPvwGvAAoJEKeha0olJ0Nq9tQH/A/WhsI6BxpYJIWH9wMMzYMe McX9ZetEemmpq91hLbiSh/IomLTRWcUJrrds1TfsywMYfLHjrat0e69Q5pfR0a/6 nSZFvYMHG8Uzl1ueNidQwKr6Nq+m5x273IYlOgYlBNfAquZS5uHKevQSyObi3gB5 FeUuP7pPMZRLmqRZm+EoN80mFrwxN020vX0Ppc82H/qLOdS+jic7Apjyhx/X6jZE 6N2dS8MqRcvNy38IaB1pBCqvP43g+uwBYY04DSf/Q0mZKXNTZS+hLsO60R0yTVi1 RszAZdYqsYTDID53P2l64ONLdKBlB2YAVgLVLmzemGbnQE9wuDnaVrFT2pY3Ze8= =n4tA -----END PGP SIGNATURE----- --------------enig39D2CF01E431471A4F45F883--