From: "Andreas Färber" <afaerber@suse.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu
Date: Fri, 25 May 2012 13:42:59 +0200 [thread overview]
Message-ID: <4FBF7043.1030503@suse.de> (raw)
In-Reply-To: <a215b3101ede9409d31c28515c3127d14964e3db.1337944756.git.gxt@mprc.pku.edu.cn>
Am 25.05.2012 13:29, schrieb Guan Xuetao:
> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
> target-unicore32/cpu.c | 17 +++++++++++++----
> target-unicore32/cpu.h | 2 +-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c
> index de63f58..62c0a22 100644
> --- a/target-unicore32/cpu.c
> +++ b/target-unicore32/cpu.c
> @@ -32,13 +32,16 @@ static void unicore_ii_cpu_initfn(Object *obj)
> UniCore32CPU *cpu = UNICORE32_CPU(obj);
> CPUUniCore32State *env = &cpu->env;
>
> - env->cp0.c0_cpuid = 0x40010863;
> + env->cp0.c0_cpuid = UC32_CPUID_UCV2;
Please don't revert this change. I'll send you the patch to drop the
CPUID #defines instead.
Andreas
> diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h
> index 66c42f5..8af3649 100644
> --- a/target-unicore32/cpu.h
> +++ b/target-unicore32/cpu.h
> @@ -123,7 +123,7 @@ void cpu_asr_write(CPUUniCore32State *env1, target_ulong val, target_ulong mask)
> #define UC32_HWCAP_UCF64 8 /* 1 << 3 */
>
> #define UC32_CPUID(env) (env->cp0.c0_cpuid)
> -#define UC32_CPUID_UCV2 0x40010863
> +#define UC32_CPUID_UCV2 0x4d000863
> #define UC32_CPUID_ANY 0xffffffff
>
> #define cpu_init uc32_cpu_init
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-05-25 11:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 11:28 [Qemu-devel] [PATCH 0/9] *** SUBJECT HERE *** Guan Xuetao
2012-05-25 11:28 ` [Qemu-devel] [PATCH 1/9] unicore32-softmmu: make exceptions generated in unicore32 architecture Guan Xuetao
2012-05-25 11:29 ` [Qemu-devel] [PATCH 2/9] unicore32-softmmu: implement some softmmu specific functions Guan Xuetao
2012-05-25 11:29 ` [Qemu-devel] [PATCH 3/9] unicore32-softmmu: add coprocessor 0 and ocd instruction support Guan Xuetao
2012-05-25 11:29 ` [Qemu-devel] [PATCH 4/9] unicore32-softmmu: make sure that kernel can access user space Guan Xuetao
2012-05-25 11:29 ` [Qemu-devel] [PATCH 5/9] unicore32-softmmu: initialize ucv2 cpu Guan Xuetao
2012-05-25 11:42 ` Andreas Färber [this message]
2012-05-28 9:43 ` guanxuetao
2012-05-28 13:14 ` Andreas Färber
2012-05-25 11:29 ` [Qemu-devel] [PATCH 6/9] unicore32-softmmu: add generic cpu state save/load functions Guan Xuetao
2012-05-25 11:44 ` Andreas Färber
2012-05-28 9:45 ` guanxuetao
2012-05-25 11:45 ` 陳韋任
2012-05-25 11:29 ` [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support Guan Xuetao
2012-05-25 11:46 ` Andreas Färber
2012-05-28 9:58 ` guanxuetao
2012-05-25 11:29 ` [Qemu-devel] [PATCH 8/9] unicore32-softmmu: add config and makefile support Guan Xuetao
2012-05-25 11:48 ` Andreas Färber
2012-05-28 10:08 ` guanxuetao
2012-05-28 13:46 ` Andreas Färber
2012-05-25 11:29 ` [Qemu-devel] [PATCH 9/9] unicore32-softmmu: add maintainer information Guan Xuetao
2012-05-25 11:30 ` [Qemu-devel] [PATCH 0/9] *** SUBJECT HERE *** Guan Xuetao
2012-05-25 12:09 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBF7043.1030503@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).