From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55988)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXsys-0006Hc-5v
	for qemu-devel@nongnu.org; Fri, 25 May 2012 07:47:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXsyn-00042C-Go
	for qemu-devel@nongnu.org; Fri, 25 May 2012 07:46:53 -0400
Received: from cantor2.suse.de ([195.135.220.15]:42916 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SXsyn-000423-Al
	for qemu-devel@nongnu.org; Fri, 25 May 2012 07:46:49 -0400
Message-ID: <4FBF7124.2090607@suse.de>
Date: Fri, 25 May 2012 13:46:44 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1337944756.git.gxt@mprc.pku.edu.cn>
	<a62c67c68a66732675372fbfe353a04c49565735.1337944756.git.gxt@mprc.pku.edu.cn>
In-Reply-To: <a62c67c68a66732675372fbfe353a04c49565735.1337944756.git.gxt@mprc.pku.edu.cn>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/9] unicore32-softmmu: add puv3 soc support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

Am 25.05.2012 13:29, schrieb Guan Xuetao:
> This patch only add minimal necessary system-control modules simulation
> for successfully kernel booting and busybox running.
>=20
> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
> ---
>  hw/pkunity/puv3.c      |  130 ++++++++++++++++++++++++++++++++++++++++=
+
>  hw/pkunity/puv3.h      |   49 ++++++++++++++++
>  hw/pkunity/puv3_dma.c  |  109 ++++++++++++++++++++++++++++++++++
>  hw/pkunity/puv3_gpio.c |  141 ++++++++++++++++++++++++++++++++++++++++=
++++
>  hw/pkunity/puv3_intc.c |  135 ++++++++++++++++++++++++++++++++++++++++=
++
>  hw/pkunity/puv3_ost.c  |  151 ++++++++++++++++++++++++++++++++++++++++=
++++++++
>  hw/pkunity/puv3_pm.c   |  148 ++++++++++++++++++++++++++++++++++++++++=
+++++++
>  7 files changed, 863 insertions(+), 0 deletions(-)
>  create mode 100644 hw/pkunity/puv3.c
>  create mode 100644 hw/pkunity/puv3.h
>  create mode 100644 hw/pkunity/puv3_dma.c
>  create mode 100644 hw/pkunity/puv3_gpio.c
>  create mode 100644 hw/pkunity/puv3_intc.c
>  create mode 100644 hw/pkunity/puv3_ost.c
>  create mode 100644 hw/pkunity/puv3_pm.c

Added a subdirectory without adapting configure and possibly Makefiles
will break out-of-tree builds. Can't you just name the files
puv3_something.[ch] as done for other SoCs?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg