From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXugo-0007Nk-NA for qemu-devel@nongnu.org; Fri, 25 May 2012 09:36:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXugg-0006SG-Jt for qemu-devel@nongnu.org; Fri, 25 May 2012 09:36:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXugg-0006Rs-BZ for qemu-devel@nongnu.org; Fri, 25 May 2012 09:36:14 -0400 Message-ID: <4FBF8AC7.8050400@redhat.com> Date: Fri, 25 May 2012 15:36:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337787881-3579-1-git-send-email-pbonzini@redhat.com> <1337787881-3579-8-git-send-email-pbonzini@redhat.com> <4FBF89D2.1020901@suse.de> In-Reply-To: <4FBF89D2.1020901@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: imammedo@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , peter.maydell@linaro.org Il 25/05/2012 15:32, Andreas F=E4rber ha scritto: > Am 23.05.2012 17:44, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> hw/qdev-properties.c | 487 +++++-----------------------------------= --------- >> hw/qdev.c | 47 +---- >> hw/qdev.h | 87 --------- >> include/qemu/object.h | 98 ++++++++++ >> qom/object.c | 459 ++++++++++++++++++++++++++++++++++++++++= ++++++ >> 5 files changed, 604 insertions(+), 574 deletions(-) >=20 > I'm not so fond of blowing up object.c with stuff that was originally i= n > its own file. Had you considered a new qom/object-properties.c? I hadn't, but it can be done. I can do it next week, or review the result, as you prefer. Paolo