From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYRrK-00078O-77 for qemu-devel@nongnu.org; Sat, 26 May 2012 21:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYRrI-0006d6-FN for qemu-devel@nongnu.org; Sat, 26 May 2012 21:01:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59236 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYRrI-0006cl-9L for qemu-devel@nongnu.org; Sat, 26 May 2012 21:01:24 -0400 Message-ID: <4FC17CD9.4020904@suse.de> Date: Sun, 27 May 2012 03:01:13 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1338078550-22119-1-git-send-email-afaerber@suse.de> In-Reply-To: <1338078550-22119-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Luiz Capitulino , Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 27.05.2012 02:29, schrieb Andreas F=C3=A4rber: > Dependency files qom/*.d were not included by Makefile, causing changes > in object.h (e.g., changes to struct Object) not to propagate to > qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list. >=20 > libuser/qom/cpu.o was unaffected since Makefile.user includes */*.d. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/Makefile b/Makefile > index 9b7a85e..0bb0529 100644 > --- a/Makefile > +++ b/Makefile > @@ -400,4 +400,4 @@ tar: > rm -rf /tmp/$(FILE) > =20 > # Include automatically generated dependency files > --include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d q= api/*.d qga/*.d) > +-include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d q= api/*.d qga/*.d qom/*.d) I wonder if, independently of QOM, we also need to consider... - qapi-generated/*.d, - usb/*.d and - tests/*.d? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg