* [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies
@ 2012-05-27 0:29 Andreas Färber
2012-05-27 1:01 ` Andreas Färber
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2012-05-27 0:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Andreas Färber, Anthony Liguori
Dependency files qom/*.d were not included by Makefile, causing changes
in object.h (e.g., changes to struct Object) not to propagate to
qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list.
libuser/qom/cpu.o was unaffected since Makefile.user includes */*.d.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 9b7a85e..0bb0529 100644
--- a/Makefile
+++ b/Makefile
@@ -400,4 +400,4 @@ tar:
rm -rf /tmp/$(FILE)
# Include automatically generated dependency files
--include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d)
+-include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d qom/*.d)
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies
2012-05-27 0:29 [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies Andreas Färber
@ 2012-05-27 1:01 ` Andreas Färber
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Färber @ 2012-05-27 1:01 UTC (permalink / raw)
To: Anthony Liguori, Luiz Capitulino, Gerd Hoffmann; +Cc: Paolo Bonzini, qemu-devel
Am 27.05.2012 02:29, schrieb Andreas Färber:
> Dependency files qom/*.d were not included by Makefile, causing changes
> in object.h (e.g., changes to struct Object) not to propagate to
> qom-qobject.o, container.o and cpu.o. Add qom/*.d to the wildcard list.
>
> libuser/qom/cpu.o was unaffected since Makefile.user includes */*.d.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9b7a85e..0bb0529 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -400,4 +400,4 @@ tar:
> rm -rf /tmp/$(FILE)
>
> # Include automatically generated dependency files
> --include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d)
> +-include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d qom/*.d)
I wonder if, independently of QOM, we also need to consider...
- qapi-generated/*.d,
- usb/*.d and
- tests/*.d?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-27 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-27 0:29 [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies Andreas Färber
2012-05-27 1:01 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).