From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYdGl-00030Q-PT
	for qemu-devel@nongnu.org; Sun, 27 May 2012 09:12:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYdGj-0007h1-ID
	for qemu-devel@nongnu.org; Sun, 27 May 2012 09:12:27 -0400
Received: from cantor2.suse.de ([195.135.220.15]:49584 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SYdGj-0007gw-BP
	for qemu-devel@nongnu.org; Sun, 27 May 2012 09:12:25 -0400
Message-ID: <4FC22830.4090705@suse.de>
Date: Sun, 27 May 2012 15:12:16 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1338008201-29078-1-git-send-email-ronniesahlberg@gmail.com>
	<1338008201-29078-5-git-send-email-ronniesahlberg@gmail.com>
	<jpq16n$7jd$1@dough.gmane.org>
In-Reply-To: <jpq16n$7jd$1@dough.gmane.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC
 device,
 then force the use of sg. We dont have any medium changer emulation so only
 passthrough via real sg or scsi-generic via iscsi would work anyway.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org

Am 26.05.2012 09:36, schrieb Paolo Bonzini:
> Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto:
>> Forcing sg also makes qemu skip trying to read from the device to gues=
s the image format by reading from the device (find_image_format()).
>> SMC devices do not implement READ6/10/12/16  so it is noit possible to=
 read from them.
>>
>> With this patch I can successfully manage a SMC device wiht iscsi in p=
assthrough mode.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
[...]
> Modified to also do the same for tapes, applied to scsi-next branch for=
 1.2.

Paolo, it seems you haven't pushed scsi-next since then. I hope you've
also shortened the subject to a humanly bearable length?

Ronnie, please restrict commit message lines to at most 76 characters.
You can check by running `git log` in an 80-char-wide terminal. The
subject line is especially sensitive since this email subject is simply
unreadable. And Patchwork currently looks really ugly in WebKit due to
this patch subject.

https://live.gnome.org/Git/CommitMessages

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg