From: Jan Kiszka <jan.kiszka@web.de>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Lee Essen <lee.essen@nowonline.co.uk>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-1.1] slirp: Untangle TCPOLEN_* from TCPOPT_*
Date: Mon, 28 May 2012 13:46:55 +0200 [thread overview]
Message-ID: <4FC365AF.7000104@web.de> (raw)
In-Reply-To: <4FC267AF.3060706@web.de>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On 2012-05-27 19:43, Andreas Färber wrote:
> Am 28.04.2012 00:29, schrieb Andreas Färber:
>> From: Andreas Färber <andreas.faerber@web.de>
>>
>> Commit b72210568ef0c0fb141a01cffb71a09c4efa0364 (slirp: clean up
>> conflicts with system headers) enclosed TCPOLEN_MAXSEG with an #ifdef
>> TCPOPT_EOL. This broke the build on illumos, which has TCPOPT_*
>> but not TCPOLEN_*.
>>
>> Move them to their own #ifdef TCPOLEN_MAXSEG section to remedy this.
>>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>
> Ping! It seems this patch has not been applied yet despite agreement
> between Blue and Jan that we should apply this least-invasive version
> for 1.1. Please apply / include in a PULL for rc4.
Thanks, queued for 1.1. I'll send a pull as soon as the other small
build fixes are available.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
prev parent reply other threads:[~2012-05-28 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335565745-22708-1-git-send-email-afaerber@suse.de>
2012-05-27 17:43 ` [Qemu-devel] [PATCH for-1.1] slirp: Untangle TCPOLEN_* from TCPOPT_* Andreas Färber
2012-05-28 11:46 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC365AF.7000104@web.de \
--to=jan.kiszka@web.de \
--cc=andreas.faerber@web.de \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=lee.essen@nowonline.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).