From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYyQd-0000QR-I5 for qemu-devel@nongnu.org; Mon, 28 May 2012 07:48:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYyQb-0003Xp-Mz for qemu-devel@nongnu.org; Mon, 28 May 2012 07:48:03 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:45856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYyQb-0003XA-DY for qemu-devel@nongnu.org; Mon, 28 May 2012 07:48:01 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate01.web.de (Postfix) with ESMTP id 89C7D1AEF9978 for ; Mon, 28 May 2012 13:47:35 +0200 (CEST) Message-ID: <4FC365D6.80205@web.de> Date: Mon, 28 May 2012 13:47:34 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1338136940-53279-1-git-send-email-andreas.faerber@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF550F0ADBD44F78252B4DD66" Subject: Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF550F0ADBD44F78252B4DD66 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-05-28 00:10, Peter Maydell wrote: > On 27 May 2012 17:42, Andreas F=C3=A4rber wrot= e: >> +# if defined(__APPLE__) >> +# undef NTOHL >> +# undef NTOHS >> +# undef HTONL >> +# undef HTONS >> +# define NTOHL(d) do { } while (0) >> +# define NTOHS(d) do { } while (0) >> +# define HTONL(d) do { } while (0) >> +# define HTONS(d) do { } while (0) >> +# else >=20 > We could just use this for everything, not just if __APPLE__, > right? For big-endian the semantics we want are always "do > nothing" so it's always OK to undef and redefine... > That would save having a special case. Yes, please. Jan --------------enigF550F0ADBD44F78252B4DD66 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/DZdYACgkQitSsb3rl5xTL3gCg03ho6XKcrDwWvzk1ZKsO9gqZ C48AoIAnuqPd0GrZFkrlYyjyHZrzNHo9 =K36D -----END PGP SIGNATURE----- --------------enigF550F0ADBD44F78252B4DD66--