From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYygV-0005m3-55 for qemu-devel@nongnu.org; Mon, 28 May 2012 08:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYygT-0000Ep-Fo for qemu-devel@nongnu.org; Mon, 28 May 2012 08:04:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYygT-0000Eb-8f for qemu-devel@nongnu.org; Mon, 28 May 2012 08:04:25 -0400 Message-ID: <4FC369C2.3000503@redhat.com> Date: Mon, 28 May 2012 15:04:18 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4FBD9E3A.6080704@web.de> <4FBE1A98.3090708@siemens.com> <4FBE26AF.2090103@siemens.com> <4FBE3716.6040205@siemens.com> <4FBE4518.4000402@redhat.com> <4FC346B6.7060400@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Blue Swirl , Jan Kiszka , qemu-devel , TeLeMan On 05/28/2012 02:54 PM, Max Filippov wrote: >>> >>> Right. If the fix is going to be checked in then TeLeMan's original version >>> with '|' is preferable for this reason. >> >> I disagree. Whatever we call cpu_get_phys_page_debug() has to either >> mask out the low bits, or not (I prefer the latter, since it's >> unambiguous for large pages), but it has to be consistent. Once it's >> consistent, there's no reason to use clever tricks. > > I meant a one line fix for the 1.1. I suspect that fixing entire > cpu_get_phys_page_debug thing for 1.1 is too risky. > Agree for 1.1. -- error compiling committee.c: too many arguments to function