From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SYyhq-0006bm-2Z
	for qemu-devel@nongnu.org; Mon, 28 May 2012 08:05:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SYyhj-0000gR-T2
	for qemu-devel@nongnu.org; Mon, 28 May 2012 08:05:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SYyhj-0000gA-KS
	for qemu-devel@nongnu.org; Mon, 28 May 2012 08:05:43 -0400
Message-ID: <4FC36A12.1010508@redhat.com>
Date: Mon, 28 May 2012 14:05:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1338008201-29078-1-git-send-email-ronniesahlberg@gmail.com>
	<1338008201-29078-5-git-send-email-ronniesahlberg@gmail.com>
	<jpq16n$7jd$1@dough.gmane.org> <4FC22830.4090705@suse.de>
	<4FC31FBF.1090200@redhat.com>
	<CAN05THRhQAwYv7_aROj+QC66NcwSXfE3MOMn0Rovkdw5fsyL+w@mail.gmail.com>
In-Reply-To: <CAN05THRhQAwYv7_aROj+QC66NcwSXfE3MOMn0Rovkdw5fsyL+w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] ISCSI: If the device we open is a SMC
 device,
 then force the use of sg. We dont have any medium changer emulation so only
 passthrough via real sg or scsi-generic via iscsi would work anyway.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, qemu-devel@nongnu.org

Il 28/05/2012 13:55, ronnie sahlberg ha scritto:
> Paolo
> 
> 
> I think I have seen a problem inside libiscsi that could be triggered
> by the shortcut.
> 
> Can you remove this shortcut completely :
> 
> -    /* Try to write as much as we can to the socket
> -     * without setting up an event.
> -     * Only do this if we are completely logged in, so we know that
> -     * the socket is in connected state.
> -     */
> -    if (iscsi_is_logged_in(iscsi)) {
> -        if (iscsi_which_events(iscsi) & POLLOUT) {
> -            iscsi_process_write(iscsilun);
> -        }
> -    }
> 
> I think there is a problem inside libiscsi if the socket becomes full
> and is no longer writeable and we try to write via this shortcurcuit.
> It will take a while until I can verify or fix that issue and before a
> new version of libiscsi can be available
> so I would feel most comfortable with if we just remove this
> optimization from QEMU for now.
> 
> It can be added back later once libiscsi is fixed.

Done.  Rebased scsi-next, new commit is
f4dfa67f04037c1b1a8f4e4ddc944c5ab308f35b.

Paolo