From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ1vb-0004uG-48 for qemu-devel@nongnu.org; Mon, 28 May 2012 11:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ1vZ-0006UP-A5 for qemu-devel@nongnu.org; Mon, 28 May 2012 11:32:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57017 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ1vZ-0006UL-48 for qemu-devel@nongnu.org; Mon, 28 May 2012 11:32:13 -0400 Message-ID: <4FC39A76.4030006@suse.de> Date: Mon, 28 May 2012 17:32:06 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337808401-24717-1-git-send-email-sw@weilnetz.de> <4FC31E0A.5070408@weilnetz.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Stefan Weil , Anthony Liguori , qemu-devel@nongnu.org, Peter Maydell Am 28.05.2012 17:18, schrieb malc: > On Mon, 28 May 2012, Stefan Weil wrote: >=20 >> Am 28.05.2012 06:11, schrieb Peter Maydell: >>> On 23 May 2012 22:26, Stefan Weil wrote: >>>> When DEBUG_ES1370 is defined, the compiler shows these warnings: >>>> >>>> hw/es1370.c: In function ?es1370_update_voices?: >>>> hw/es1370.c:414: warning: format ?%d? expects type ?int?, but argume= nt 3 >>>> has type ?size_t? >>> The unicode quotes in this commit message seem to have got smashed to >>> question-mark characters at some point between this email and it hitt= ing >>> git master :-( >>> >>> -- PMM >> >> Malc, could you please check your git workflow? >=20 > Pine's '|' does that with my LC_CTYPE it seems, have to either ctrl-w=20 > after '|' or export, either way - can do. Recently I suspected your mailer and on one of the TCG threads suggested to download from Patchwork instead. But Patchwork also has its flaws: It tries to add *-bys from the replies, in the order it receives them rather than where they were placed and, like Anthony's mailbox script, it might pick up false positives. And when there's line-wrapping in the original mail it might silently drop part of the patch or in the combination of line-wrapping and patch attachment drop and duplicate parts. So if you can fix by some clever scripting that'll be safest. :) Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg