From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SaS8J-0006OZ-36 for qemu-devel@nongnu.org; Fri, 01 Jun 2012 09:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SaS8G-0004v9-Re for qemu-devel@nongnu.org; Fri, 01 Jun 2012 09:43:14 -0400 Received: from goliath.siemens.de ([192.35.17.28]:15266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SaS8G-0004uj-H8 for qemu-devel@nongnu.org; Fri, 01 Jun 2012 09:43:12 -0400 Message-ID: <4FC8C6EB.6000704@siemens.com> Date: Fri, 01 Jun 2012 15:43:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4FC65E19.6090203@siemens.com> <4FC65F70.4040501@siemens.com> <20120530182356.GD32721@redhat.com> <20120530182913.GE32721@redhat.com> <20120530185150.GA1546@redhat.com> <4FC66FB1.9050306@siemens.com> <20120530193034.GE1551@redhat.com> <4FC681B4.3030807@web.de> <20120530203119.GH1551@redhat.com> <4FC8BB28.8000004@siemens.com> <20120601132834.GB21451@redhat.com> In-Reply-To: <20120601132834.GB21451@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Alex Williamson , Marcelo Tosatti , qemu-devel , Avi Kivity On 2012-06-01 15:28, Michael S. Tsirkin wrote: > On Fri, Jun 01, 2012 at 02:52:56PM +0200, Jan Kiszka wrote: >> On 2012-05-30 22:31, Michael S. Tsirkin wrote: >>>>> So we'll just have PIIX_NUM_PIC_IRQS entries there and use >>>>> irq_count instead of the pic_levels bitmap. >>>> >>>> Just that this affects generic PCI code, not only PIIX-specific things. >>> >>> Yes but it's not a problem - pci_bus_irqs sets the map function and nirqs. >>> >>>> And that we need to save/restore some irq_count field according to the >>>> old semantics. >>> >>> Well, it's a bug: this is redundant info we should not have exposed it. >>> >>> Anyway, let's make the rest work properly and cleanly first, add a FIXME >>> for now, then we'll find a hack making it work for migration. >> >> It remains non-trivial: I got your patch working (a minor init issue), >> but yet without changing the number of IRQs for PIIX3, so keeping the >> irq_count semantics for this host bridge. > > BTW can you post the fixed version please in case > others want to play with it? Pushed a snapshot to git://git.kiszka.org/qemu.git queues/pci. That version survived simple tests. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux