From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Sb8ox-0007Lp-LP
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:18:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Sb8ov-0002wZ-VM
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:18:07 -0400
Received: from smtp4-g21.free.fr ([212.27.42.4]:52067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1Sb8ov-0002vU-Cf
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 07:18:05 -0400
Message-ID: <4FCB47E5.9080502@reactos.org>
Date: Sun, 03 Jun 2012 13:17:57 +0200
From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1338719890-9935-1-git-send-email-hpoussin@reactos.org>
	<1338719890-9935-8-git-send-email-hpoussin@reactos.org>
	<20120603104648.GD3640@redhat.com>
In-Reply-To: <20120603104648.GD3640@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI
	SCSI adapter)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

Michael S. Tsirkin a =E9crit :
> On Sun, Jun 03, 2012 at 12:38:09PM +0200, Herv=E9 Poussineau wrote:
>> The PCI version is supported in lots of Operating Systems,
>> and has been successfully tested on:
>> - MS DOS 6.22 with MS Windows 3.11
>> - MS Windows 98 SE
>> - MS Windows NT 4.0
>>
>> Signed-off-by: Herv=E9 Poussineau <hpoussin@reactos.org>

...

>> +
>> +static void pci_handle_abort(PCIESPState *pci, uint32_t val)
>> +{
>> +    trace_esp_pci_dma_abort(val);
>> +    if (pci->esp.current_req) {
>> +        scsi_req_cancel(pci->esp.current_req);
>> +    }
>> +}
>> +
>=20
> It is better to prefix all global scope symbols with
> esp_ consistently. Reduces the chance of a conflict.

All these functions are local to the file. I'll change that to=20
pci_esp_... like other PCI-related functions in this file.

>=20
>> +static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint3=
2_t val)
>> +{
>> +    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
>> +    switch (saddr) {
>> +    case DMA_CMD:
>> +        pci->dma_regs[saddr] =3D val;
>> +        switch (val & DMA_CMD_MASK) {
>> +        case 0x0: /* IDLE */
>> +            trace_esp_pci_dma_idle(val);
>> +            break;
>> +        case 0x1: /* BLAST */
>> +            pci_handle_blast(pci, val);
>=20
> fall-through intentional?

Not at all. Thanks.

Herv=E9