From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SbEfd-0004Kr-DC
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 13:32:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SbEfb-0007x7-ON
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 13:32:52 -0400
Received: from mail-wg0-f41.google.com ([74.125.82.41]:51921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SbEfb-0007ws-FZ
	for qemu-devel@nongnu.org; Sun, 03 Jun 2012 13:32:51 -0400
Received: by wgbds1 with SMTP id ds1so1885847wgb.4
	for <qemu-devel@nongnu.org>; Sun, 03 Jun 2012 10:32:49 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCB9FBD.8080700@redhat.com>
Date: Sun, 03 Jun 2012 19:32:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1338726358-30681-1-git-send-email-pbonzini@redhat.com>
	<1338726358-30681-7-git-send-email-pbonzini@redhat.com>
	<CAAu8pHvb0=7N_HsmKPg3+G0Zhp8p6g4bMYm_t=q-oOoR4NQgog@mail.gmail.com>
In-Reply-To: <CAAu8pHvb0=7N_HsmKPg3+G0Zhp8p6g4bMYm_t=q-oOoR4NQgog@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/24] move libobj-y variable to nested
	Makefile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Il 03/06/2012 15:42, Blue Swirl ha scritto:
>> >  # HELPER_CFLAGS is used for all the legacy code compiled with static register
>> >  # variables
>> > -ifneq ($(TARGET_BASE_ARCH), sparc)
>> > -op_helper.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
>> > -endif
>> > +%/op_helper.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
> This should be target specific.
> 
> Overall, the target-* changes will conflict with AREG0 conversion,
> perhaps those  patches should be postponed.

It's difficult to convert Makefile.objs without doing Makefile.target
first.  Not a big deal though, the conflicts are easy for me to resolve.

Paolo