From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbPGp-00063e-ST for qemu-devel@nongnu.org; Mon, 04 Jun 2012 00:52:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbPGn-0000tB-TJ for qemu-devel@nongnu.org; Mon, 04 Jun 2012 00:51:59 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:36223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbPGn-0000sr-MV for qemu-devel@nongnu.org; Mon, 04 Jun 2012 00:51:57 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 3 Jun 2012 22:51:52 -0600 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DFAF2C9005A for ; Mon, 4 Jun 2012 00:51:49 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q544poWu107010 for ; Mon, 4 Jun 2012 00:51:50 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q544pktq015457 for ; Mon, 4 Jun 2012 01:51:49 -0300 Message-ID: <4FCC3EDF.5070101@us.ibm.com> Date: Mon, 04 Jun 2012 12:51:43 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338778001-1863-1-git-send-email-zwu.kernel@gmail.com> In-Reply-To: <1338778001-1863-1-git-send-email-zwu.kernel@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 1.2 00/16] hub-based networking patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zwu.kernel@gmail.com Cc: stefanha@linux.vnet.ibm.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, Zhi Yong Wu , luowenj@cn.ibm.com, pbonzini@redhat.com On 06/04/2012 10:46 AM, zwu.kernel@gmail.com wrote: > From: Zhi Yong Wu > > All comments from other guys were addressed. v3 had review comments from Paolo that you acknowledged. I don't see a v4 on the list. You cannot do a pull request of unposted patches. Stefan, can I assume you Reviewed-by this whole series? I don't see any explicit Reviewed-bys in v3. Regards, Anthony Liguori > > The following changes since commit a854972f8cdec0148087789d62777d8f7176933d: > > Update version to open the 1.2 development branch (Fri Jun 1 16:56:16 2012 +0800) > > are available in the git repository at: > > git@github.com:wuzhy/qemu.git for-anthony > > Stefan Hajnoczi (12): > net: Add a hub net client > net: Use hubs for the vlan feature > net: Look up 'vlan' net clients using hubs > hub: Check that hubs are configured correctly > net: Drop vlan argument to qemu_new_net_client() > net: Remove vlan qdev property > net: Remove vlan code from net.c > net: Remove VLANState > net: Rename non_vlan_clients to net_clients > net: Rename VLANClientState to NetClientState > net: Rename vc local variables to nc > net: Rename qemu_del_vlan_client() to qemu_del_net_client() > > Zhi Yong Wu (4): > net: Make "info network" output more readable info > net: cleanup deliver/deliver_iov func pointers > net: determine if packets can be sent before net queue deliver > packets > hub: add the support for hub own flow control > > Makefile.objs | 2 +- > hw/cadence_gem.c | 8 +- > hw/dp8393x.c | 6 +- > hw/e1000.c | 10 +- > hw/eepro100.c | 8 +- > hw/etraxfs_eth.c | 8 +- > hw/lan9118.c | 8 +- > hw/lance.c | 2 +- > hw/mcf_fec.c | 6 +- > hw/milkymist-minimac2.c | 6 +- > hw/mipsnet.c | 6 +- > hw/musicpal.c | 6 +- > hw/ne2000-isa.c | 2 +- > hw/ne2000.c | 8 +- > hw/ne2000.h | 4 +- > hw/opencores_eth.c | 8 +- > hw/pcnet-pci.c | 4 +- > hw/pcnet.c | 6 +- > hw/pcnet.h | 6 +- > hw/qdev-properties.c | 78 +------ > hw/qdev.c | 2 - > hw/qdev.h | 8 +- > hw/rtl8139.c | 10 +- > hw/smc91c111.c | 6 +- > hw/spapr_llan.c | 4 +- > hw/stellaris_enet.c | 6 +- > hw/usb/dev-network.c | 8 +- > hw/vhost_net.c | 24 +- > hw/vhost_net.h | 2 +- > hw/virtio-net.c | 12 +- > hw/xen_nic.c | 7 +- > hw/xgmac.c | 6 +- > hw/xilinx_axienet.c | 6 +- > hw/xilinx_ethlite.c | 6 +- > net.c | 605 ++++++++++++++--------------------------------- > net.h | 86 ++++---- > net/dump.c | 28 ++- > net/dump.h | 2 +- > net/hub.c | 310 ++++++++++++++++++++++++ > net/hub.h | 28 +++ > net/queue.c | 37 ++-- > net/queue.h | 25 +-- > net/slirp.c | 32 +-- > net/slirp.h | 2 +- > net/socket.c | 66 +++--- > net/socket.h | 2 +- > net/tap-win32.c | 27 +- > net/tap.c | 45 ++-- > net/tap.h | 21 +- > net/vde.c | 17 +- > net/vde.h | 3 +- > qemu-common.h | 3 +- > slirp/if.c | 5 - > slirp/libslirp.h | 1 - > 54 files changed, 818 insertions(+), 826 deletions(-) > create mode 100644 net/hub.c > create mode 100644 net/hub.h >