From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60622)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1SbQHC-0006SJ-Kt
	for qemu-devel@nongnu.org; Mon, 04 Jun 2012 01:56:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1SbQHA-0006HQ-VS
	for qemu-devel@nongnu.org; Mon, 04 Jun 2012 01:56:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47727)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1SbQHA-0006Gk-NI
	for qemu-devel@nongnu.org; Mon, 04 Jun 2012 01:56:24 -0400
Message-ID: <4FCC4E69.5040009@redhat.com>
Date: Mon, 04 Jun 2012 13:58:01 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <20120510083717.45992.7495.stgit@amd-6168-8-1.englab.nay.redhat.com>
	<4FCC4C23.9020007@us.ibm.com>
In-Reply-To: <4FCC4C23.9020007@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host
 communication only in normal operating mode"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On 06/04/2012 01:48 PM, Anthony Liguori wrote:
> On 05/10/2012 04:37 PM, Jason Wang wrote:
>> This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is 
>> because
>> the linux 8139cp driver would leave the card in "Config Register 
>> Write Enable"
>> mode after the eeprom were read or write ( which is unexpected in the 
>> spec
>> ). Also a physical 8139 card can still DMA into host memory in modes 
>> other than
>> Normal mode, so we need revert this commit to align with the behavior of
>> physical card.
>>
>> The issue of 8139cp driver should be fixed in linux seperately.
>>
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
>
> Applied.  Thanks.
>
> Regards,
>
> Anthony Liguori

Hi Anthony:

Michael has some concern on this patch, so I post another patch of 
validating the rx buf instead of checking the opmode, please see 
http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02385.html. So 
maybe we can apply that or I need to send another patch on top of this 
reverting?

Thanks