From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbQuC-0006s7-EE for qemu-devel@nongnu.org; Mon, 04 Jun 2012 02:36:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbQuA-0006jF-Q4 for qemu-devel@nongnu.org; Mon, 04 Jun 2012 02:36:43 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:45754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbQuA-0006hn-GX for qemu-devel@nongnu.org; Mon, 04 Jun 2012 02:36:42 -0400 Received: by wgbfm10 with SMTP id fm10so3439952wgb.10 for ; Sun, 03 Jun 2012 23:36:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FCC5775.6050704@redhat.com> Date: Mon, 04 Jun 2012 08:36:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1338726358-30681-1-git-send-email-pbonzini@redhat.com> <4FCBE7D1.80907@suse.de> <4FCBEBE8.9060600@codemonkey.ws> In-Reply-To: <4FCBEBE8.9060600@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Il 04/06/2012 00:57, Anthony Liguori ha scritto: >> >> As before, I dislike the use of the filename "Makefile" for files that >> are not self-contained. If make is called from that deep directory, it >> leads to undefined results. Either we must make sure through some clever >> ifeq'ery and a local "all" target that such an attempt fails, or better >> use a filename that is recognized by editors as Makefile syntax but not >> used by make without explicit -f, e.g., foo.mak. > > Linux does this. I think it's expected behavior at this point. In the > long term, we should either move to kconfig or autoconf so trying to act > like one of the two seems like a good idea to me. This is not really necessary; we won't really move to kbuild anytime. I don't really like the magic Makefiles and did it only because Linux does this. Naming files Makefile.objs would make just as much sense. Paolo