From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbTiN-00039r-Tu for qemu-devel@nongnu.org; Mon, 04 Jun 2012 05:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbTiI-0007HY-RR for qemu-devel@nongnu.org; Mon, 04 Jun 2012 05:36:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbTiI-0007Gw-KX for qemu-devel@nongnu.org; Mon, 04 Jun 2012 05:36:38 -0400 Message-ID: <4FCC81A0.3080707@redhat.com> Date: Mon, 04 Jun 2012 11:36:32 +0200 From: Kevin Wolf MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , qemu-devel , Peter Maydell Am 03.06.2012 19:38, schrieb Blue Swirl: > Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF > (for implemented cases) or to use LOG_UNIMP (unimplemented). > > Signed-off-by: Blue Swirl I would suggest that you check the messages of those cases that became FLOPPY_DPRINTF(). Originally the macro printed "FLOPPY ERROR: " and now it's not even mentioned any more that it is an error message, making messages like "writing sector %d" totally misleading. If you fix that up: Acked-by: Kevin Wolf