From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbWPF-0006co-9x for qemu-devel@nongnu.org; Mon, 04 Jun 2012 08:29:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbWP9-0007cm-0e for qemu-devel@nongnu.org; Mon, 04 Jun 2012 08:29:08 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:51941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbWP8-0007be-QA for qemu-devel@nongnu.org; Mon, 04 Jun 2012 08:29:02 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Jun 2012 06:28:58 -0600 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 56905C90052 for ; Mon, 4 Jun 2012 08:28:54 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q54CSrDn24969414 for ; Mon, 4 Jun 2012 08:28:54 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q54HxjE3016658 for ; Mon, 4 Jun 2012 13:59:45 -0400 Message-ID: <4FCCAA01.5040708@us.ibm.com> Date: Mon, 04 Jun 2012 20:28:49 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <20120510083717.45992.7495.stgit@amd-6168-8-1.englab.nay.redhat.com> <4FCC4C23.9020007@us.ibm.com> <4FCC4E69.5040009@redhat.com> In-Reply-To: <4FCC4E69.5040009@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: mst@redhat.com, qemu-devel@nongnu.org, avi@redhat.com On 06/04/2012 01:58 PM, Jason Wang wrote: > On 06/04/2012 01:48 PM, Anthony Liguori wrote: >> On 05/10/2012 04:37 PM, Jason Wang wrote: >>> This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is because >>> the linux 8139cp driver would leave the card in "Config Register Write Enable" >>> mode after the eeprom were read or write ( which is unexpected in the spec >>> ). Also a physical 8139 card can still DMA into host memory in modes other than >>> Normal mode, so we need revert this commit to align with the behavior of >>> physical card. >>> >>> The issue of 8139cp driver should be fixed in linux seperately. >>> >>> Signed-off-by: Jason Wang >> >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > Hi Anthony: > > Michael has some concern on this patch, so I post another patch of validating > the rx buf instead of checking the opmode, please see > http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02385.html. So maybe we > can apply that or I need to send another patch on top of this reverting? I'll work it all out. Regards, Anthony Liguori > > Thanks >