From: Kevin Wolf <kwolf@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org,
stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/3] Sample server that opens image files for QEMU
Date: Mon, 04 Jun 2012 17:01:34 +0200 [thread overview]
Message-ID: <4FCCCDCE.2080903@redhat.com> (raw)
In-Reply-To: <1338815410-24890-4-git-send-email-coreyb@linux.vnet.ibm.com>
Am 04.06.2012 15:10, schrieb Corey Bryant:
> This sample server opens image files and passes the fds to QEMU. The
> paths for two image files are passed as parameters, the first being
> the boot image, and the second being an image to be hot-attached. The
> server will open the files and pass the fds to QEMU in one of two ways:
>
> 1) Over the command line (using -drive file=/dev/fd/X) or
> 2) Via the QMP monitor with the getfd command (using SCM_RIGHTS)
> followed by drive_add (using file=/dev/fd/X) and then
> device_add.
>
> Usage:
> gcc -Wall -o test-fd-passing test-fd-passing.c -L/usr/local/lib -ljson
> ./test-fd-passing /path/hda.img /path/hdb.img
>
> Note: This requires json-c and json-c-devel packages.
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> test-fd-passing.c | 321 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 321 insertions(+)
> create mode 100644 test-fd-passing.c
Is this meant to be applied or just for reference?
Maybe we can make a proper test case out of it that runs during make
check? Would probably require that the json-c dependency is dropped,
though. Maybe we should rewrite it in Python, as we already have QMP
bindings for that (and there are already tests that use them).
Kevin
next prev parent reply other threads:[~2012-06-04 15:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 13:10 [Qemu-devel] [PATCH 0/3] file descriptor passing using getfd over QMP Corey Bryant
2012-06-04 13:10 ` [Qemu-devel] [PATCH 1/3] qmp/hmp: Add QMP getfd command that returns fd Corey Bryant
2012-06-04 14:45 ` Kevin Wolf
2012-06-04 15:57 ` Corey Bryant
2012-06-05 18:30 ` Luiz Capitulino
2012-06-06 14:04 ` Corey Bryant
2012-06-06 17:50 ` Luiz Capitulino
2012-06-06 19:42 ` Corey Bryant
2012-06-08 10:46 ` Daniel P. Berrange
2012-06-08 13:17 ` Corey Bryant
2012-06-04 13:10 ` [Qemu-devel] [PATCH 2/3] block: Add support to "open" /dev/fd/X filenames Corey Bryant
2012-06-04 14:32 ` Eric Blake
2012-06-04 15:51 ` Corey Bryant
2012-06-04 16:03 ` Eric Blake
2012-06-04 16:28 ` Corey Bryant
2012-06-04 16:36 ` Eric Blake
2012-06-04 16:40 ` Corey Bryant
2012-06-04 14:54 ` Kevin Wolf
2012-06-04 16:07 ` Corey Bryant
2012-06-04 13:10 ` [Qemu-devel] [PATCH 3/3] Sample server that opens image files for QEMU Corey Bryant
2012-06-04 15:01 ` Kevin Wolf [this message]
2012-06-04 16:15 ` Corey Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCCDCE.2080903@redhat.com \
--to=kwolf@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).