From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SbnHs-0004En-HU
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 02:30:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SbnHm-0006vF-H9
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 02:30:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SbnHm-0006v5-97
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 02:30:34 -0400
Message-ID: <4FCDA786.3030203@redhat.com>
Date: Tue, 05 Jun 2012 08:30:30 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1338726358-30681-1-git-send-email-pbonzini@redhat.com>
	<1338726358-30681-20-git-send-email-pbonzini@redhat.com>
	<4FCCF9AF.4040806@suse.de>
In-Reply-To: <4FCCF9AF.4040806@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 19/24] convert libhw to nested Makefiles
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 06/04/12 20:08, Andreas F=E4rber wrote:
> Am 03.06.2012 14:25, schrieb Paolo Bonzini:
>> diff --git a/hw/usb/Makefile b/hw/usb/Makefile
>> index 7dbc33b..9c7ddf5 100644
>> --- a/hw/usb/Makefile
>> +++ b/hw/usb/Makefile
>> @@ -1,3 +1,12 @@
>> +hw-obj-$(CONFIG_USB_UHCI) +=3D hcd-uhci.o
>> +hw-obj-$(CONFIG_USB_OHCI) +=3D hcd-ohci.o
>> +hw-obj-$(CONFIG_USB_EHCI) +=3D hcd-ehci.o
>> +hw-obj-$(CONFIG_USB_XHCI) +=3D hcd-xhci.o
>> +hw-obj-y +=3D libhw.o
>=20
> Why a libhw.o in hw/usb/?

That are the core usb bits which need to go into libhw{32,64}.

The usb_packet_{map,unmap} functions which operate on QEMUSGList are
living there.

cheers,
  Gerd