From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Sbq1m-0004ev-3r
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 05:26:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Sbq1b-0005dU-Rw
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 05:26:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Sbq1b-0005dB-Ju
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 05:26:03 -0400
Message-ID: <4FCDD0A5.6000800@redhat.com>
Date: Tue, 05 Jun 2012 11:25:57 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1338858018-17189-3-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1338858018-17189-3-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, yamahata@valinux.co.jp, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de

Am 05.06.2012 03:00, schrieb Michael Roth:
> Define away the annotations so we can still compile.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  qapi/qc.h |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>  create mode 100644 qapi/qc.h
> 
> diff --git a/qapi/qc.h b/qapi/qc.h
> new file mode 100644
> index 0000000..3b3a8b9
> --- /dev/null
> +++ b/qapi/qc.h
> @@ -0,0 +1,11 @@
> +#ifndef QC_H
> +#define QC_H
> +
> +#define qc_declaration
> +#define _immutable
> +#define _derived
> +#define _broken
> +#define _version(x)
> +#define _size_is(x)
> +
> +#endif

I believe there are still ways to improve the documentation here. :-)

At the very least there should be a reference to the documentation of
patch 1.

Kevin