From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SbqxL-0004Nt-5g
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 06:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SbqxE-0002bw-Tf
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 06:25:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1SbqxE-0002bm-LI
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 06:25:36 -0400
Message-ID: <4FCDDE98.50604@redhat.com>
Date: Tue, 05 Jun 2012 13:25:28 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1338858018-17189-10-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1338858018-17189-10-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/17] rtc: add qc annotations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, yamahata@valinux.co.jp, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de

On 06/05/2012 04:00 AM, Michael Roth wrote:
> Add our annotations according to QIDL documentation.
> 
> +qc_declaration typedef struct RTCState {
> +    ISADevice _immutable dev;
> +    MemoryRegion _immutable io;
>      uint8_t cmos_data[128];
>      uint8_t cmos_index;
>      struct tm current_tm;
>      int32_t base_year;
> -    qemu_irq irq;
> -    qemu_irq sqw_irq;
> -    int it_shift;
> +    qemu_irq _immutable irq;
> +    qemu_irq _immutable sqw_irq;

How is qemu_irq immutable? We're raising and lowering it many times a
second.  It's _derived, perhaps, but not immutable.

> +    int32_t _immutable it_shift;
>      /* periodic timer */
>      QEMUTimer *periodic_timer;
>      int64_t next_periodic_time;
>      /* second update */
>      int64_t next_second_time;
> -    uint16_t irq_reinject_on_ack_count;
> +    uint16_t _derived irq_reinject_on_ack_count;

It's not derived from anything.  It's _host, maybe.

>      uint32_t irq_coalesced;
>      uint32_t period;
> -    QEMUTimer *coalesced_timer;
> +    QEMUTimer _broken *coalesced_timer;
>      QEMUTimer *second_timer;
>      QEMUTimer *second_timer2;
> -    Notifier clock_reset_notifier;
> -    LostTickPolicy lost_tick_policy;
> -    Notifier suspend_notifier;
> +    Notifier _broken clock_reset_notifier;

Why broken?

> +    LostTickPolicy _immutable lost_tick_policy;

_host; nothign prevents us from changing it dynamically in theory.

> +    Notifier _broken suspend_notifier;

Why broken?

>  } RTCState;
>  
>  #endif /* !MC146818RTC_STATE_H */


-- 
error compiling committee.c: too many arguments to function