From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbruT-00027C-FX for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbruN-0003CB-9O for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:26:49 -0400 Received: from david.siemens.de ([192.35.17.14]:32265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbruM-0003BT-W5 for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:26:43 -0400 Message-ID: <4FCDECEB.5040708@siemens.com> Date: Tue, 05 Jun 2012 13:26:35 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-3-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDE0F4.2010202@siemens.com> <4FCDE9A8.7060301@us.ibm.com> In-Reply-To: <4FCDE9A8.7060301@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/17] qidl: add qc definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "yamahata@valinux.co.jp" , "quintela@redhat.com" , Michael Roth , "qemu-devel@nongnu.org" , "owasserm@redhat.com" , "pbonzini@redhat.com" , "akong@redhat.com" , "afaerber@suse.de" On 2012-06-05 13:12, Anthony Liguori wrote: > On 06/05/2012 06:35 PM, Jan Kiszka wrote: >> On 2012-06-05 03:00, Michael Roth wrote: >>> Define away the annotations so we can still compile. >>> >>> Signed-off-by: Michael Roth >>> --- >>> qapi/qc.h | 11 +++++++++++ >>> 1 files changed, 11 insertions(+), 0 deletions(-) >>> create mode 100644 qapi/qc.h >>> >>> diff --git a/qapi/qc.h b/qapi/qc.h >>> new file mode 100644 >>> index 0000000..3b3a8b9 >>> --- /dev/null >>> +++ b/qapi/qc.h >>> @@ -0,0 +1,11 @@ >>> +#ifndef QC_H >>> +#define QC_H >>> + >>> +#define qc_declaration >>> +#define _immutable >>> +#define _derived >>> +#define _broken >>> +#define _version(x) >>> +#define _size_is(x) >>> + >>> +#endif >> >> These tags require a different prefix than the reserved '_'. > > The rationale is that QIDL is part of the "compiler/library implementation" that > this namespace is reserved for. It's a QEMU-internal thing, and we want to be portable. Not sure if it's worth to risk collisions in some distant corner. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux