From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbsQC-0007ZA-IH for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:59:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SbsQA-00023A-P3 for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:59:36 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:62246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SbsQA-00022x-IZ for qemu-devel@nongnu.org; Tue, 05 Jun 2012 07:59:34 -0400 Received: by pbbro12 with SMTP id ro12so7969954pbb.4 for ; Tue, 05 Jun 2012 04:59:32 -0700 (PDT) Message-ID: <4FCDF49E.6090006@codemonkey.ws> Date: Tue, 05 Jun 2012 19:59:26 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338875386-21051-1-git-send-email-yhalperi@redhat.com> In-Reply-To: <1338875386-21051-1-git-send-email-yhalperi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin Cc: aliguori@us.ibm.com, alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On 06/05/2012 01:49 PM, Yonit Halperin wrote: > Hi, > > I'm sending this patch series again. This time with an additional patch > for setting a migrate_end notifier completion callback for spice migration > interface. I've also added more detailed commit messages. > > This patch series introduces async handlers for notifiers, and integrates them > with migration state change notifications. > > Asynchronous migration completion notifier is essential for allowing spice to cleanly > complete the src server connection to the client, and transfer the connection to the target. > Currently, as soon as the migration completes, the src qemu can be closed by the > management, and spice cannot complete the spice-connection migration. > > In order to support spice seamless migration, next to these patches, I plan to add: > (1) notifier for switching from the live phase of the migration to the non-live phase, > before completing savevm. > Spice will use this notification to "finalize" the connection to the client: send > and receive all in-flight data. Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the migration traffic. That's a terrible idea. I'd like to be more constructive in my response, but you aren't explaining the problem well enough for me to offer an alternative solution. You need to find another way to solve this problem. Regards, Anthony Liguori