From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1Sbswb-0001WB-8R
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 08:33:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1SbswV-0003vL-Uz
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 08:33:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65204)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phrdina@redhat.com>) id 1SbswV-0003uu-Mr
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 08:32:59 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q55CWuDx024549
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 5 Jun 2012 08:32:57 -0400
Message-ID: <4FCDFC75.4010906@redhat.com>
Date: Tue, 05 Jun 2012 14:32:53 +0200
From: Pavel Hrdina <phrdina@redhat.com>
MIME-Version: 1.0
References: <cover.1337849630.git.phrdina@redhat.com>
	<1cab04f5945f130fad0d576378d71acd36c0c13e.1337849630.git.phrdina@redhat.com>
	<20120605025429.GA19285@amt.cnet>
	<m3wr3mmg3q.fsf@blackfin.pond.sub.org>
	<20120605100550.GA2778@amt.cnet>
	<m3hauq7ylh.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3hauq7ylh.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible
 after start without media
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 06/05/2012 02:05 PM, Markus Armbruster wrote:
> Marcelo Tosatti<mtosatti@redhat.com>  writes:
>
>> On Tue, Jun 05, 2012 at 08:23:53AM +0200, Markus Armbruster wrote:
>>> Marcelo Tosatti<mtosatti@redhat.com>  writes:
>>>
>>>> On Thu, May 24, 2012 at 11:02:28AM +0200, Pavel Hrdina wrote:
>>>>> If you start guest with floppy drive but without media inserted, guest
>>>>> still should see floppy drive pressent.
>>>>>
>>>>> Signed-off-by: Pavel Hrdina<phrdina@redhat.com>
>>>>> ---
>>>>>   hw/pc.c |    2 +-
>>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/hw/pc.c b/hw/pc.c
>>>>> index 4d34a33..967c17a 100644
>>>>> --- a/hw/pc.c
>>>>> +++ b/hw/pc.c
>>>>> @@ -382,7 +382,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size,
>>>>>       if (floppy) {
>>>>>           fdc_get_bs(fd, floppy);
>>>>>           for (i = 0; i<  2; i++) {
>>>>> -            if (fd[i]&&  bdrv_is_inserted(fd[i])) {
>>>>> +            if (fd[i]) {
>>>>>                   bdrv_get_floppy_geometry_hint(fd[i],&nb_heads,&max_track,
>>>>>                                                 &last_sect, FDRIVE_DRV_NONE,
>>>>>                                                 &fd_type[i],&rate);
>>>>> -- 
>>>> This commit breaks WinXP.32 installation. It crashes during early setup
>>>> stage, without a floppy disk specified.
>>>>
>>>> Specifying a floppy disk with -fda fixes the problem.
>>> Backtrace?
>> None, WinXP is spinning (presumably the floppy driver).
> Bummer.  Pavel, can you look into this?
Hi, I have just read this issue. Sure, I will look into.