From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35875)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc0tN-0004NU-Qx
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:02:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc0tE-0002rB-Mq
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:02:17 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:36247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc0tE-0002r6-ED
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:02:08 -0400
Received: by pbbro12 with SMTP id ro12so8650239pbb.4
	for <qemu-devel@nongnu.org>; Tue, 05 Jun 2012 14:02:06 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCE73C8.6030906@redhat.com>
Date: Tue, 05 Jun 2012 23:02:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337683555-13301-1-git-send-email-lersek@redhat.com>
	<1337683555-13301-13-git-send-email-lersek@redhat.com>
In-Reply-To: <1337683555-13301-13-git-send-email-lersek@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/16] convert net_init_socket() to
	NetClientOptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org

Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
> +    if (sock->has_fd + sock->has_listen + sock->has_connect + sock->has_mcast +
> +        sock->has_udp != 1) {

Please add a cast, this doesn't work with C99 bool.

Paolo

> +        error_report("exactly one of fd=, listen=, connect=, mcast= or udp="
> +                     " is required");
> +        return -1;
> +    }